[whispersystems] TextSecure - Configurable repeat interval

[Carey Metcalfe]

I know how much adding options is hated here, but I thought I'd propose one
nonetheless.

In the notification settings, there's a "Repeat alerts" option. Although
there's no user-facing documentation on this, by looking at the source (and
experimenting) it seems it makes the notification repeat every 10 seconds
for a
configurable number of times.

Allowing the user to chose how many times it repeats but not how often (or
even
telling them how often) seems a little strange. In fact, a user opened an
issue
against SMSSecure (a downstream project that only does SMS encryption)
asking
for the ability to change the interval.

Issue: https://github.com/SMSSecure/SMSSecure/issues/104.

I thought it was a pretty reasonable request so I went ahead and took a
stab at
implementing it.

Commit:
https://github.com/SMSSecure/SMSSecure/commit/40652ad8afcc8b998ed0646b92cb238b8db9633d
Some screenshots: http://imgur.com/a/oEKl3

Is this option something TextSecure would consider adding? If so, I can
rebase
my changes against TextSecure, make a pull request (and fix any issues with
it), then pull it downstream into SMSSecure when it's merged in. If not,
I'll
just merge it directly into SMSSecure.

I saw some discussion of this option in a pull request for TextSecure
(https://github.com/WhisperSystems/TextSecure/pull/1623), but there didn't
seem
to be a conclusive answer.

Ideally, I'd like to see both applications improve, but if this option isn't
something that TextSecure wants, that's fine too.

Carey (https://github.com/pR0Ps)

[agrajaghh]

Hey Carey,

I already proposed this at the IRC channel but I guess here are more
people reading it:
I think it might be an option to integrate both options into one
dialog/activity, this would keep the list of preferences short. I'm not
sure yet how you could do this exactly (two sliders, two drop down
menus, etc.), but I think it's worth considering...

best regards

Post by Carey Metcalfe
I know how much adding options is hated here, but I thought I'd propose one
nonetheless.
In the notification settings, there's a "Repeat alerts" option. Although
there's no user-facing documentation on this, by looking at the source (and
experimenting) it seems it makes the notification repeat every 10
seconds for a
configurable number of times.
Allowing the user to chose how many times it repeats but not how often
(or even
telling them how often) seems a little strange. In fact, a user opened
an issue
against SMSSecure (a downstream project that only does SMS encryption)
asking
for the ability to change the interval.
Issue: https://github.com/SMSSecure/SMSSecure/issues/104.
I thought it was a pretty reasonable request so I went ahead and took
a stab at
implementing it.
https://github.com/SMSSecure/SMSSecure/commit/40652ad8afcc8b998ed0646b92cb238b8db9633d
Some screenshots: http://imgur.com/a/oEKl3
Is this option something TextSecure would consider adding? If so, I
can rebase
my changes against TextSecure, make a pull request (and fix any issues with
it), then pull it downstream into SMSSecure when it's merged in. If
not, I'll
just merge it directly into SMSSecure.
I saw some discussion of this option in a pull request for TextSecure
(https://github.com/WhisperSystems/TextSecure/pull/1623), but there
didn't seem
to be a conclusive answer.
Ideally, I'd like to see both applications improve, but if this option isn't
something that TextSecure wants, that's fine too.
Carey (https://github.com/pR0Ps)

[Moxie Marlinspike]

We talked about it when putting the feature in, and decided not to make
the interval period configurable. What we do now is actually identical
to iMessage. If it's repeating every 10 seconds, that wasn't the
intent, and is a bug.

- moxie

Post by agrajaghh
Hey Carey,
I already proposed this at the IRC channel but I guess here are more
I think it might be an option to integrate both options into one
dialog/activity, this would keep the list of preferences short. I'm not
sure yet how you could do this exactly (two sliders, two drop down
menus, etc.), but I think it's worth considering...
best regards

Post by Carey Metcalfe
I know how much adding options is hated here, but I thought I'd propose one
nonetheless.
In the notification settings, there's a "Repeat alerts" option. Although
there's no user-facing documentation on this, by looking at the source (and
experimenting) it seems it makes the notification repeat every 10
seconds for a
configurable number of times.
Allowing the user to chose how many times it repeats but not how often
(or even
telling them how often) seems a little strange. In fact, a user opened
an issue
against SMSSecure (a downstream project that only does SMS encryption)
asking
for the ability to change the interval.
Issue: https://github.com/SMSSecure/SMSSecure/issues/104.
I thought it was a pretty reasonable request so I went ahead and took
a stab at
implementing it.
https://github.com/SMSSecure/SMSSecure/commit/40652ad8afcc8b998ed0646b92cb238b8db9633d
Some screenshots: http://imgur.com/a/oEKl3
Is this option something TextSecure would consider adding? If so, I
can rebase
my changes against TextSecure, make a pull request (and fix any issues with
it), then pull it downstream into SMSSecure when it's merged in. If
not, I'll
just merge it directly into SMSSecure.
I saw some discussion of this option in a pull request for TextSecure
(https://github.com/WhisperSystems/TextSecure/pull/1623), but there
didn't seem
to be a conclusive answer.
Ideally, I'd like to see both applications improve, but if this option isn't
something that TextSecure wants, that's fine too.
Carey (https://github.com/pR0Ps)

[Carey Metcalfe]

Found an image online of the iMessage setup for reference:
Loading Image...

Currently it's repeating the correct number of times at a hardcoded 10
second interval (here:
https://github.com/WhisperSystems/TextSecure/blob/master/src/org/thoughtcrime/securesms/notifications/MessageNotifier.java#L422
).

You're saying it should just be 2 minute intervals instead?

Carey

Post by Moxie Marlinspike
We talked about it when putting the feature in, and decided not to make
the interval period configurable. What we do now is actually identical
to iMessage. If it's repeating every 10 seconds, that wasn't the
intent, and is a bug.
- moxie

Post by agrajaghh
Hey Carey,
I already proposed this at the IRC channel but I guess here are more
I think it might be an option to integrate both options into one
dialog/activity, this would keep the list of preferences short. I'm not
sure yet how you could do this exactly (two sliders, two drop down
menus, etc.), but I think it's worth considering...
best regards

Post by Carey Metcalfe
I know how much adding options is hated here, but I thought I'd propose one
nonetheless.
In the notification settings, there's a "Repeat alerts" option. Although
there's no user-facing documentation on this, by looking at the source (and
experimenting) it seems it makes the notification repeat every 10
seconds for a
configurable number of times.
Allowing the user to chose how many times it repeats but not how often
(or even
telling them how often) seems a little strange. In fact, a user opened
an issue
against SMSSecure (a downstream project that only does SMS encryption)
asking
for the ability to change the interval.
Issue: https://github.com/SMSSecure/SMSSecure/issues/104.
I thought it was a pretty reasonable request so I went ahead and took
a stab at
implementing it.

https://github.com/SMSSecure/SMSSecure/commit/40652ad8afcc8b998ed0646b92cb238b8db9633d

Post by agrajaghh

Post by Carey Metcalfe
Some screenshots: http://imgur.com/a/oEKl3
Is this option something TextSecure would consider adding? If so, I
can rebase
my changes against TextSecure, make a pull request (and fix any issues with
it), then pull it downstream into SMSSecure when it's merged in. If
not, I'll
just merge it directly into SMSSecure.
I saw some discussion of this option in a pull request for TextSecure
(https://github.com/WhisperSystems/TextSecure/pull/1623), but there
didn't seem
to be a conclusive answer.
Ideally, I'd like to see both applications improve, but if this option isn't
something that TextSecure wants, that's fine too.
Carey (https://github.com/pR0Ps)

--
http://www.thoughtcrime.org

[Patrick Connolly]

Exponential or fibonacci backoff might fit for the repeat period here. Less
attention noise seems double-plus good.

Post by Carey Metcalfe
http://media.idownloadblog.com/wp-content/uploads/2014/04/Double-Notifications1-1024x905.png
Currently it's repeating the correct number of times at a hardcoded 10
https://github.com/WhisperSystems/TextSecure/blob/master/src/org/thoughtcrime/securesms/notifications/MessageNotifier.java#L422
).
You're saying it should just be 2 minute intervals instead?
Carey

Post by Moxie Marlinspike
We talked about it when putting the feature in, and decided not to make
the interval period configurable. What we do now is actually identical
to iMessage. If it's repeating every 10 seconds, that wasn't the
intent, and is a bug.
- moxie

Post by agrajaghh
Hey Carey,
I already proposed this at the IRC channel but I guess here are more
I think it might be an option to integrate both options into one
dialog/activity, this would keep the list of preferences short. I'm not
sure yet how you could do this exactly (two sliders, two drop down
menus, etc.), but I think it's worth considering...
best regards

Post by Carey Metcalfe
I know how much adding options is hated here, but I thought I'd propose one
nonetheless.
In the notification settings, there's a "Repeat alerts" option.

Although

Post by agrajaghh

Post by Carey Metcalfe
there's no user-facing documentation on this, by looking at the source (and
experimenting) it seems it makes the notification repeat every 10
seconds for a
configurable number of times.
Allowing the user to chose how many times it repeats but not how often
(or even
telling them how often) seems a little strange. In fact, a user opened
an issue
against SMSSecure (a downstream project that only does SMS encryption)
asking
for the ability to change the interval.
Issue: https://github.com/SMSSecure/SMSSecure/issues/104.
I thought it was a pretty reasonable request so I went ahead and took
a stab at
implementing it.

https://github.com/SMSSecure/SMSSecure/commit/40652ad8afcc8b998ed0646b92cb238b8db9633d

Post by agrajaghh

Post by Carey Metcalfe
Some screenshots: http://imgur.com/a/oEKl3
Is this option something TextSecure would consider adding? If so, I
can rebase
my changes against TextSecure, make a pull request (and fix any issues with
it), then pull it downstream into SMSSecure when it's merged in. If
not, I'll
just merge it directly into SMSSecure.
I saw some discussion of this option in a pull request for TextSecure
(https://github.com/WhisperSystems/TextSecure/pull/1623), but there
didn't seem
to be a conclusive answer.
Ideally, I'd like to see both applications improve, but if this option isn't
something that TextSecure wants, that's fine too.
Carey (https://github.com/pR0Ps)

--
http://www.thoughtcrime.org

[Bryan Phelps]

Agreed. Although I've never tried the feature because sometimes I like to ignore a text and check my phone later, it is a setting that should be considered.

On the other hand, if it's been running at 10 second intervals this whole time and this is the first time hearing about it... I'd have to question it's priority of use. Obviously not many use it as is, so if you want to increase its usage than correcting (or allowing configuration) of the interval would be a good idea. Otherwise it's mostly a wasted option no one uses.

On April 15, 2015 2:58:22 PM CDT, Simon Effenberg <***@schuldeigen.de> wrote:
|If it would be 2 minutes I would start using the feature (right now it
|is unusable).
|
|But why we should not have the option to specify the delay is probably
|a
|Gnome way of thinking. Then also the "LED-Color" would be a
|questionable
|option, wouldn't it? (please don't change that! I only want to compare
|them :))
|
|Cheers
|Simon
|
|On Wed, Apr 15, 2015 at 03:49:26PM -0400, Patrick Connolly wrote:
|> Exponential or fibonacci backoff might fit for the repeat period
|here.
|> Less attention noise seems double-plus good.
|>
|> On Wed, Apr 15, 2015 at 3:09 PM, Carey Metcalfe
|<***@cmetcalfe.ca>
|> wrote:
|>
|> Found an image online of the iMessage setup for reference:
|>
|http://media.idownloadblog.com/wp-content/uploads/2014/04/Double-Notifications1-1024x905.png
|>
|> Currently it's repeating the correct number of times at a
|hardcoded 10
|> second interval (here:
|>
|https://github.com/WhisperSystems/TextSecure/blob/master/src/org/thoughtcrime/securesms/notifications/MessageNotifier.java#L422
|> ).
|>
|> You're saying it should just be 2 minute intervals instead?
|>
|> Carey
|> On Wed, Apr 15, 2015 at 2:57 PM, Moxie Marlinspike
|> <***@thoughtcrime.org> wrote:
|>
|> We talked about it when putting the feature in, and decided
|not to
|> make
|> the interval period configurable.A What we do now is
|actually
|> identical
|> to iMessage.A If it's repeating every 10 seconds, that
|wasn't the
|> intent, and is a bug.
|>
|> - moxie
|> On 04/15/2015 11:55 AM, agrajaghh wrote:
|> > Hey Carey,
|> >
|> > I already proposed this at the IRC channel but I guess here
|are more
|> > people reading it:
|> > I think it might be an option to integrate both options
|into one
|> > dialog/activity, this would keep the list of preferences
|short. I'm
|> not
|> > sure yet how you could do this exactly (two sliders, two
|drop down
|> > menus, etc.), but I think it's worth considering...
|> >
|> > best regards
|> >
|> > Am 15.04.2015 um 20:25 schrieb Carey Metcalfe:
|> >> I know how much adding options is hated here, but I
|thought I'd
|> >> propose one
|> >> nonetheless.
|> >>
|> >> In the notification settings, there's a "Repeat alerts"
|option.
|> Although
|> >> there's no user-facing documentation on this, by looking
|at the
|> source
|> >> (and
|> >> experimenting) it seems it makes the notification repeat
|every 10
|> >> seconds for a
|> >> configurable number of times.
|> >>
|> >> Allowing the user to chose how many times it repeats but
|not how
|> often
|> >> (or even
|> >> telling them how often) seems a little strange. In fact, a
|user
|> opened
|> >> an issue
|> >> against SMSSecure (a downstream project that only does SMS
|> encryption)
|> >> asking
|> >> for the ability to change the interval.
|> >>
|> >> Issue: https://github.com/SMSSecure/SMSSecure/issues/104.
|> >>
|> >> I thought it was a pretty reasonable request so I went
|ahead and
|> took
|> >> a stab at
|> >> implementing it.
|> >>
|> >> Commit:
|> >>
|>
|https://github.com/SMSSecure/SMSSecure/commit/40652ad8afcc8b998ed0646b92cb238b8db9633d
|> >> Some screenshots: http://imgur.com/a/oEKl3
|> >>
|> >> Is this option something TextSecure would consider adding?
|If so, I
|> >> can rebase
|> >> my changes against TextSecure, make a pull request (and
|fix any
|> issues
|> >> with
|> >> it), then pull it downstream into SMSSecure when it's
|merged in. If
|> >> not, I'll
|> >> just merge it directly into SMSSecure.
|> >>
|> >> I saw some discussion of this option in a pull request for
|> TextSecure
|> >> (https://github.com/WhisperSystems/TextSecure/pull/1623),
|but there
|> >> didn't seem
|> >> to be a conclusive answer.
|> >>
|> >> Ideally, I'd like to see both applications improve, but if
|this
|> option
|> >> isn't
|> >> something that TextSecure wants, that's fine too.
|> >>
|> >> Carey (https://github.com/pR0Ps)
|> >
|> >
|>
|> --
|> http://www.thoughtcrime.org

--Bryan Phelps

[Moxie Marlinspike]

Post by Carey Metcalfe
You're saying it should just be 2 minute intervals instead?

Yes. That's the only change I would consider.

- moxie

[Shi Jian]

Hi all,
Does anyone know how to change the default port of TS server in local.yml?
I try to add following:

server:
applicationConnectors:
- type: http
port: 9090
adminConnectors:
- type: http
port: 9091

But I got this when I run the server:Failed to parse configuration at :server.

Best Regards

________________________________
This message and any attachments are intended solely for the addressees and may contain confidential information. Any unauthorized use or disclosure, either whole or partial, is prohibited.
E-mails are susceptible to alteration. Our company shall not be liable for the message if altered, changed or falsified. If you are not the intended recipient of this message, please delete it and notify the sender.
Although all reasonable efforts have been made to keep this transmission free from viruses, the sender will not be liable for damages caused by a tran

[Moxie Marlinspike]

Shi, this is not a user support forum. These kinds of questions are not
appropriate.

- moxie

Post by Shi Jian
Hi all,
Does anyone know how to change the default port of TS server in local.yml?
- type: http
port: 9090
- type: http
port: 9091
But I got this when I run the server:Failed to parse configuration at :server.
Best Regards
________________________________
This message and any attachments are intended solely for the addressees and may contain confidential information. Any unauthorized use or disclosure, either whole or partial, is prohibited.
E-mails are susceptible to alteration. Our company shall not be liable for the message if altered, changed or falsified. If you are not the intended recipient of this message, please delete it and notify the sender.
Although all reasonable efforts have been made to keep this transmission free from viruses, the sender will not be liable for damages caused by a transmitted virus.