[whispersystems] Code style Guidelines missing

[agrajaghh]

Hey everyone,

since the Redphone/Textsecure merge, the Code style Guidelines are
missing/deleted:
https://github.com/WhisperSystems/RedPhone/wiki/Code-style-Guidelines

They are referenced here:
https://github.com/WhisperSystems/Signal-Android/wiki
https://github.com/WhisperSystems/Signal-Android/blob/master/contributing.md

Did someone save them or is it possible for the OWS members to restore
them in the Signal-Android wiki? Sometimes its usefull to mention them
in PRs...

best regards

["Manuel Geier" (via whispersystems Mailing List)]

I wanted to point out the same thing too ;)
In addition: I use Android Studio.Where can I find the proper code style settings for the code formatting, which everyone should use? -> .idea/codeStyleSettings.xmlhttp://stackoverflow.com/questions/9087439/how-to-share-code-style-settings-between-developers-in-intellij

I always use the auto-format option, but the default code style settings are not used within the project.We may can should think about using the default code style settings.What do you think about that?I know that this may not be the best idea, because we have a huge existing code base and we will "lose" some information in our CVS if we reformat the whole code now. So, a shared code style setting file is a good idea.
Best regards!


agrajaghh <***@gmail.com> schrieb am 14:12 Mittwoch, 4.November 2015:


Hey everyone,

since the Redphone/Textsecure merge, the Code style Guidelines are
missing/deleted:
https://github.com/WhisperSystems/RedPhone/wiki/Code-style-Guidelines

They are referenced here:
https://github.com/WhisperSystems/Signal-Android/wiki
https://github.com/WhisperSystems/Signal-Android/blob/master/contributing.md

Did someone save them or is it possible for the OWS members to restore
them in the Signal-Android wiki? Sometimes its usefull to mention them
in PRs...

best regards

[Jake McGinty]

I modified Square’s code styles to be better-fitting for OWS’s guidelines:

https://github.com/mcginty/java-code-styles <https://github.com/mcginty/java-code-styles>

It isn’t magic, as IntelliJ doesn’t match the functionality of Tabifier for example, but it’s better than the default.

Post by "Manuel Geier" (via whispersystems Mailing List)
I wanted to point out the same thing too ;)
In addition: I use Android Studio.
Where can I find the proper code style settings for the code formatting, which everyone should use? -> .idea/codeStyleSettings.xml
http://stackoverflow.com/questions/9087439/how-to-share-code-style-settings-between-developers-in-intellij <http://stackoverflow.com/questions/9087439/how-to-share-code-style-settings-between-developers-in-intellij>
I always use the auto-format option, but the default code style settings are not used within the project.
We may can should think about using the default code style settings.
What do you think about that?
I know that this may not be the best idea, because we have a huge existing code base and we will "lose" some information in our CVS if we reformat the whole code now. So, a shared code style setting file is a good idea.
Best regards!
Hey everyone,
since the Redphone/Textsecure merge, the Code style Guidelines are
https://github.com/WhisperSystems/RedPhone/wiki/Code-style-Guidelines <https://github.com/WhisperSystems/RedPhone/wiki/Code-style-Guidelines>
https://github.com/WhisperSystems/Signal-Android/wiki <https://github.com/WhisperSystems/Signal-Android/wiki>
https://github.com/WhisperSystems/Signal-Android/blob/master/contributing.md <https://github.com/WhisperSystems/Signal-Android/blob/master/contributing.md>
Did someone save them or is it possible for the OWS members to restore
them in the Signal-Android wiki? Sometimes its usefull to mention them
in PRs...
best regards