[whispersystems] Push notifications support for the Ubuntu phone?

[Jani Monoses]

Hello,

there is a TextSecure app for the Ubuntu phone, and the most requested
feature by its tiny userbase (a few hundreds so far) is push notifications
support.

I've added Ubuntu Push server [1] support based on the existing GCM code,
tested it locally, and I wonder if there would be any obstacles for
accepting this contribution to the official server?

There's a patch for TextSecure-Server

https://github.com/WhisperSystems/TextSecure-Server/pull/62

one for the PushServer component

https://github.com/WhisperSystems/PushServer/pull/4

and a new package, heavily based on gcm-async-sender (I left in the OWS
import paths and Maven organization name, and tested it locally only,
there's no published package)

https://github.com/janimo/ups-sender-async

I'd appreciate any feedback.

Thank you,

Jani

[1]
https://developer.ubuntu.com/en/start/platform/guides/push-notifications-server-guide/

[Jani Monoses]

Post by Jani Monoses
and a new package, heavily based on gcm-async-sender (I left in the OWS
import paths and Maven organization name, and tested it locally only,
there's no published package)
https://github.com/janimo/ups-sender-async
I forgot to mention that this repo has a branch with the transformation

history from gcm-async-sender to the current state.
https://github.com/janimo/ups-sender-async/tree/gcm_to_ups_history

[Jani Monoses]

Post by Jani Monoses
Hello,
there is a TextSecure app for the Ubuntu phone, and the most requested
feature by its tiny userbase (a few hundreds so far) is push notifications
support.
I've added Ubuntu Push server [1] support based on the existing GCM code,
tested it locally, and I wonder if there would be any obstacles for
accepting this contribution to the official server?
There's a patch for TextSecure-Server
https://github.com/WhisperSystems/TextSecure-Server/pull/62
one for the PushServer component
https://github.com/WhisperSystems/PushServer/pull/4
I updated this PR so it uses the ups-sender-async package [1] recently

published in the Maven Central Repository instead of expecting it to be
provided and maintained by OWS. So there are only two PRs and no extra 3rd
repo.

Jani

[1] https://repo1.maven.org/maven2/ro/startx/ups-sender-async/0.0.2/

[L e]

Did you ever get an answer from the developers? Shame if they're ignoring your effort

From: ***@gmail.com
Date: Wed, 16 Dec 2015 19:13:09 +0200
To: ***@lists.riseup.net
Subject: Re: [whispersystems] Push notifications support for the Ubuntu phone?



On Tue, Dec 8, 2015 at 1:38 AM, Jani Monoses <***@gmail.com> wrote:
Hello,
there is a TextSecure app for the Ubuntu phone, and the most requested feature by its tiny userbase (a few hundreds so far) is push notifications support.
I've added Ubuntu Push server [1] support based on the existing GCM code, tested it locally, and I wonder if there would be any obstacles for accepting this contribution to the official server?
There's a patch for TextSecure-Server
https://github.com/WhisperSystems/TextSecure-Server/pull/62

one for the PushServer component
https://github.com/WhisperSystems/PushServer/pull/4


I updated this PR so it uses the ups-sender-async package [1] recently published in the Maven Central Repository instead of expecting it to be provided and maintained by OWS. So there are only two PRs and no extra 3rd repo.
Jani

[1] https://repo1.maven.org/maven2/ro/startx/ups-sender-async/0.0.2/

[Jani Monoses]

Post by Jani Monoses
Hello,
there is a TextSecure app for the Ubuntu phone, and the most requested
feature by its tiny userbase (a few hundreds so far) is push notifications
support.
I've added Ubuntu Push server [1] support based on the existing GCM code,
tested it locally, and I wonder if there would be any obstacles for
accepting this contribution to the official server?
There's a patch for TextSecure-Server
https://github.com/WhisperSystems/TextSecure-Server/pull/62
one for the PushServer component
https://github.com/WhisperSystems/PushServer/pull/4

As I said, I don't expect this to be anywhere near high priority for OWS,
but I am willing to implement other approaches if this code seems too
intrusive (i.e. running a separate push server for Ubuntu only using a
codebase different from the Android/iOS push server, even on another
machine if needed).

thanks
Jani

[Jeff R (LangBoost)]

I’m also interested in this solution, because the way it is handled will likely be the same as for Windows phone (together as 1 push service vs separate)


From: Jani Monoses
Sent: Wednesday, January 13, 2016 15:45
To: ***@lists.riseup.net
Subject: Re: [whispersystems] Push notifications support for the Ubuntu phone?

On Tue, Dec 8, 2015 at 1:38 AM, Jani Monoses <***@gmail.com> wrote:
Hello,

there is a TextSecure app for the Ubuntu phone, and the most requested feature by its tiny userbase (a few hundreds so far) is push notifications support.

I've added Ubuntu Push server [1] support based on the existing GCM code, tested it locally, and I wonder if there would be any obstacles for accepting this contribution to the official server?

There's a patch for TextSecure-Server

https://github.com/WhisperSystems/TextSecure-Server/pull/62

one for the PushServer component

https://github.com/WhisperSystems/PushServer/pull/4


 As I said, I don't expect this to be anywhere near high priority for OWS, but I am willing to implement other approaches if this code seems too intrusive (i.e. running a separate push server for Ubuntu only using a codebase different from the Android/iOS push server, even on another machine if needed).

thanks
Jani